github-actions[bot] commented on PR #22318: URL: https://github.com/apache/datafusion/pull/22318#issuecomment-4471813167
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-common v53.1.0 (current) Built [ 33.722s] (current) Parsing datafusion-common v53.1.0 (current) Parsed [ 0.062s] (current) Building datafusion-common v53.1.0 (baseline) Built [ 31.975s] (baseline) Parsing datafusion-common v53.1.0 (baseline) Parsed [ 0.062s] (baseline) Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.965s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field ParquetOptions.coerce_int96_tz in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:843 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 68.219s] datafusion-common Building datafusion-datasource-parquet v53.1.0 (current) Built [ 41.135s] (current) Parsing datafusion-datasource-parquet v53.1.0 (current) Parsed [ 0.029s] (current) Building datafusion-datasource-parquet v53.1.0 (baseline) Built [ 41.165s] (baseline) Parsing datafusion-datasource-parquet v53.1.0 (baseline) Parsed [ 0.029s] (baseline) Checking datafusion-datasource-parquet v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.188s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_datasource_parquet::file_format::coerce_int96_to_resolution now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/datasource-parquet/src/file_format.rs:722 datafusion_datasource_parquet::coerce_int96_to_resolution now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/datasource-parquet/src/file_format.rs:722 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 84.661s] datafusion-datasource-parquet ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
