alamb commented on code in PR #22318:
URL: https://github.com/apache/datafusion/pull/22318#discussion_r3262055234
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -713,10 +713,31 @@ pub fn apply_file_schema_type_coercions(
}
/// Coerces the file schema's Timestamps to the provided TimeUnit if Parquet
schema contains INT96.
+///
+/// Equivalent to calling [`coerce_int96_to_resolution_with_tz`] with
`timezone: None`,
+/// producing `Timestamp(time_unit, None)` for INT96-derived columns (the
historical
+/// default). Use [`coerce_int96_to_resolution_with_tz`] to attach a timezone.
Review Comment:
I guess it depends on if we want to encourage them to provide the timezone
or not.
The other thing we could do if we wanted to get (likely overly) fancy would
be to wrap it in some sort of struct
```rust
let schema = Int96Coercer::new(parquet_schema, file_schema, time_unit)
.with_timezone(..)
.coerce()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
