andygrove commented on code in PR #22318:
URL: https://github.com/apache/datafusion/pull/22318#discussion_r3262143977
##########
datafusion/common/src/config.rs:
##########
@@ -908,6 +908,16 @@ config_namespace! {
/// nanosecond resolution.
pub coerce_int96: Option<String>, transform = str::to_lowercase,
default = None
+ /// (reading) Optional timezone applied to INT96 columns when
`coerce_int96`
+ /// is set. When `Some`, INT96 columns coerce to
+ /// `Timestamp(<coerce_int96>, Some(<tz>))` instead of the default
+ /// `Timestamp(<coerce_int96>, None)`. Spark and other systems write
INT96
+ /// values as UTC-adjusted instants, so callers that need the resulting
+ /// Arrow type to be timezone-aware (e.g. for Spark `TimestampType`
+ /// semantics) should set this to `"UTC"`. No effect when
`coerce_int96`
+ /// is `None`.
+ pub coerce_int96_tz: Option<String>, default = None
Review Comment:
Oops I accepted this without testing and will need to revert. IANA timezones
are case-sensitive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]