andygrove commented on code in PR #22318: URL: https://github.com/apache/datafusion/pull/22318#discussion_r3261664280
########## datafusion/datasource-parquet/src/file_format.rs: ########## @@ -713,10 +713,31 @@ pub fn apply_file_schema_type_coercions( } /// Coerces the file schema's Timestamps to the provided TimeUnit if Parquet schema contains INT96. +/// +/// Equivalent to calling [`coerce_int96_to_resolution_with_tz`] with `timezone: None`, +/// producing `Timestamp(time_unit, None)` for INT96-derived columns (the historical +/// default). Use [`coerce_int96_to_resolution_with_tz`] to attach a timezone. Review Comment: Thanks @alamb. I wasn't sure if it was better to update the existing constructor vs adding an alternate one. This PR is a breaking change anyway since the struct can be created without using the constructor. I'm not sure if we would want to deprecate the original one since most users would just continue to use that one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
