milenkovicm commented on PR #22415: URL: https://github.com/apache/datafusion/pull/22415#issuecomment-4508457609
> > I believe its up to implementor to decide if it exposes expressions through this interfaces, or to put it differently, ExecutionPlan implementation can have expressions but not handle this call, I'm i correct ? > > I am not sure @milenkovicm -- maybe @LiaCastaneda or @adriangb (who approved the original PR) can help us add some more context about what is required to be returned and what the implications of not returning expressions are This would be great to get clarified in the upgrade manual. Ive updated ballista to 54 and left the method implementation with `todo!()` and no tests panicked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
