adriangb commented on PR #22415: URL: https://github.com/apache/datafusion/pull/22415#issuecomment-4509132635
We intend to use the method but the work has been blocked on other things. I understand why releasing a new public method that forces all implementers to make a code change with no immediate benefit is frustrating. @LiaCastaneda if we are not using this method yet what do you think or reverting / removing the API and re-adding it when we have the concrete use cases ready to merge? FWIW this API mirrors `LogicalPlan` exactly: https://github.com/apache/datafusion/blob/50d74a704d7f35a6cc184251a8f1236cd94de684/datafusion/expr/src/logical_plan/tree_node.rs#L395-L402 It's a reasonable generic method to have, there are several use cases (that like I said above got blocked, e.g. https://github.com/apache/datafusion/pull/20009 and https://github.com/apache/datafusion/pull/21350) that wanted it. It's generic to the extent that we have generic concepts for expressions and plan nodes, we did not add extra genericness for some abstract notion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
