LiaCastaneda commented on PR #22415: URL: https://github.com/apache/datafusion/pull/22415#issuecomment-4508820929
Right now nothing in DF actually uses `apply_expressions` so it does not fail. The original intention was to use it for serializing dynamic filters, but #22011 ended up going with typed getters instead. I suspect it'll get used for making Dynamic Filters and BufferExec work in #21350, and there's also interest in a read/write pair of expressions on the plan (#20009). So as of today, returning `Ok(Continue)` and skipping all expressions is actually safe. But I don't think implementing it partially (visiting some expressions but not others) is safe since the API is intended to be generic (the intention is not only for dynamic filters) and any future caller can assume you've visited everything you own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
