RyanJamesStewart commented on PR #22416: URL: https://github.com/apache/datafusion/pull/22416#issuecomment-4512809390
Done in 287a1d2. `split_vec_min_alloc` now lives in `datafusion_common::utils` and calls `shrink_to_fit` on the emitted prefix in the `split_off` branch, since that prefix keeps the original capacity and datafusion accounts memory by capacity rather than length. The duplicate helper in physical-plan's `multi_group_by/mod.rs` is removed; `bytes.rs` and `primitive.rs` now use the shared one. I also folded in the `ByteViewGroupValueBuilder::take_n` change from #22205, so this PR converts every `split_vec_min_alloc` call site in one place. #22205 will be closed as superseded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
