alamb commented on PR #22416: URL: https://github.com/apache/datafusion/pull/22416#issuecomment-4557257389
> > calling shrink-to-fit will cause a reallocation (and thus copy the data) right? > > Yes, I've already asked @RyanJamesStewart to remove `shrink_to_fit` because it could cause a reallocation if there are subsequent pushes, see [#22416 (comment)](https://github.com/apache/datafusion/pull/22416#discussion_r3285982930) and [#22416 (comment)](https://github.com/apache/datafusion/pull/22416#issuecomment-4520956360) Thank you -- sorry for my confusion. This PR now looks good to merge from my perspective. Thank you both -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
