koopatroopa787 commented on code in PR #22464:
URL: https://github.com/apache/datafusion/pull/22464#discussion_r3298366272
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -4889,10 +4889,22 @@ mod tests {
);
// The probability of being distinct is 1 - 1 / 16 = 15 / 16.
- assert_eq!(
- neq.evaluate_statistics(&[left_stat, right_stat])?,
- Distribution::new_bernoulli(ScalarValue::from(15.0 / 16.0))?
- );
+ let got = neq.evaluate_statistics(&[left_stat, right_stat])?;
+ let expected = Distribution::new_bernoulli(ScalarValue::from(15.0 /
16.0))?;
Review Comment:
It was a floating-point stabilization fix I added while debugging a local
CI run, but it doesn't belong here. I've reverted it in the latest commit and
restored the original assert_eq!. The PR now only contains the UnKnownColumn
proto hook migration as intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
