jayzhan211 commented on code in PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#discussion_r1699460386
##########
datafusion/expr/src/type_coercion/aggregates.rs:
##########
@@ -163,7 +142,7 @@ pub fn check_arg_count(
Ok(())
}
-fn get_min_max_result_type(input_types: &[DataType]) -> Result<Vec<DataType>> {
+pub fn get_min_max_result_type(input_types: &[DataType]) ->
Result<Vec<DataType>> {
Review Comment:
Implement the logic inside `coerce_types`, we don't even need this function
and test anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
