jayzhan211 commented on code in PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#discussion_r1699439613
##########
datafusion/functions-aggregate/src/min_max.rs:
##########
@@ -124,60 +186,57 @@ macro_rules! instantiate_max_accumulator {
///
/// [`ArrowPrimitiveType`]: arrow::datatypes::ArrowPrimitiveType
macro_rules! instantiate_min_accumulator {
- ($SELF:expr, $NATIVE:ident, $PRIMTYPE:ident) => {{
+ ($DATA_TYPE:ident, $NATIVE:ident, $PRIMTYPE:ident) => {{
Ok(Box::new(
- PrimitiveGroupsAccumulator::<$PRIMTYPE, _>::new(
- &$SELF.data_type,
- |cur, new| {
- if *cur > new {
- *cur = new
- }
- },
- )
+ PrimitiveGroupsAccumulator::<$PRIMTYPE, _>::new(&$DATA_TYPE, |cur,
new| {
+ if *cur > new {
+ *cur = new
+ }
+ })
// Initialize each accumulator to $NATIVE::MAX
.with_starting_value($NATIVE::MAX),
))
}};
}
-impl AggregateExpr for Max {
- /// Return a reference to Any that can be used for downcasting
- fn as_any(&self) -> &dyn Any {
+impl AggregateUDFImpl for Max {
+ fn as_any(&self) -> &dyn std::any::Any {
self
}
- fn field(&self) -> Result<Field> {
- Ok(Field::new(
- &self.name,
- self.data_type.clone(),
- self.nullable,
- ))
+ fn name(&self) -> &str {
+ "MAX"
}
- fn state_fields(&self) -> Result<Vec<Field>> {
- Ok(vec![Field::new(
- format_state_name(&self.name, "max"),
- self.data_type.clone(),
- true,
- )])
+ fn signature(&self) -> &Signature {
+ &self.signature
}
- fn expressions(&self) -> Vec<Arc<dyn PhysicalExpr>> {
- vec![Arc::clone(&self.expr)]
+ fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
Review Comment:
The code can be simplified to
```rust
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
Ok(arg_types[0].to_owned())
}
fn coerce_types(&self, arg_types: &[DataType]) -> Result<Vec<DataType>> {
let data_type = min_max_aggregate_data_type(&arg_types[0]);
Ok(vec![data_type.to_owned()])
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
