jayzhan211 commented on code in PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#discussion_r1699458067
##########
datafusion/optimizer/src/scalar_subquery_to_join.rs:
##########
@@ -393,8 +393,10 @@ mod tests {
use crate::test::*;
use arrow::datatypes::DataType;
+ // TODO: stubs or real functions
Review Comment:
For logical optimizer, it is fine to use stubs that does not have accumulator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
