JarroVGIT commented on PR #1852:
URL: 
https://github.com/apache/datafusion-ballista/pull/1852#issuecomment-4668647350

   > thanks @JarroVGIT I will have a look in details, if you agree, i would 
suggest not to introduce type for `JobName` as it has no specific meaning nor 
limitations (perhaps we should remove it from public interfaces where 
appropriate).
   
   Agree, I will remove that from this draft. Will be later today I think, or 
tomorrow morning.
   
   > regarding `ExecutorId` should we consider using uuid which that id is (and 
avoid use of strings for uuid)
   
   I will open an issue to discuss ExecutorId separately, if that's okay with 
you 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to