JarroVGIT commented on code in PR #1852:
URL:
https://github.com/apache/datafusion-ballista/pull/1852#discussion_r3389640109
##########
ballista/core/src/execution_plans/sort_shuffle/spill.rs:
##########
@@ -73,14 +74,14 @@ impl SpillManager {
/// * `compression` - Compression codec for spill files
pub fn new(
work_dir: &str,
- job_id: &str,
+ job_id: &JobId,
Review Comment:
Here is an example where references are passed, only for the method to make
it owned values. If you are interested in changing this into all `::new()` and
functions alike, I can do a pass in another PR. Low value stuff I reckon, but I
find it kinda helps me get a feel of navigating the code base so might be a win
nonetheless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
