JarroVGIT commented on code in PR #1852:
URL:
https://github.com/apache/datafusion-ballista/pull/1852#discussion_r3389826196
##########
ballista/scheduler/src/state/aqe/planner.rs:
##########
@@ -164,7 +165,11 @@ impl AdaptivePlanner {
);
let plan = state.create_physical_plan(logical_plan).await?;
- let plan = handle_explain_plan(&job_name, ctx, logical_plan, plan)
+
+ // Note: the signature requires a JobId, but we are passing a JobName.
The below is a
Review Comment:
Should I make the `handle_explain_plan` a bit more generic (e.g. name the
parameter `identifier: &str`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
