github-actions[bot] commented on PR #23161: URL: https://github.com/apache/datafusion/pull/23161#issuecomment-4789129608
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-sqllogictest v54.0.0 (current) Built [ 166.558s] (current) Parsing datafusion-sqllogictest v54.0.0 (current) Parsed [ 0.021s] (current) Building datafusion-sqllogictest v54.0.0 (baseline) Built [ 167.903s] (baseline) Parsing datafusion-sqllogictest v54.0.0 (baseline) Parsed [ 0.021s] (baseline) Checking datafusion-sqllogictest v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.101s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure enum_no_repr_variant_discriminant_changed: enum variant had its discriminant change value --- Description: The enum's variant had its discriminant value change. This breaks downstream code that used its value via a numeric cast like `as isize`. ref: https://doc.rust-lang.org/reference/items/enumerations.html#assigning-discriminant-values impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_no_repr_variant_discriminant_changed.ron Failed in: variant DFColumnType::Text 4 -> 5 in /home/runner/work/datafusion/datafusion/datafusion/sqllogictest/src/engines/output.rs:27 variant DFColumnType::Timestamp 5 -> 6 in /home/runner/work/datafusion/datafusion/datafusion/sqllogictest/src/engines/output.rs:28 variant DFColumnType::Another 6 -> 7 in /home/runner/work/datafusion/datafusion/datafusion/sqllogictest/src/engines/output.rs:29 --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_added.ron Failed in: variant DFColumnType:Decimal in /home/runner/work/datafusion/datafusion/datafusion/sqllogictest/src/engines/output.rs:26 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 337.076s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
