AdamGS opened a new pull request, #23161: URL: https://github.com/apache/datafusion/pull/23161
## Which issue does this PR close? - Closes #23160. ## Rationale for this change As described in the issue, different width decimals are currently handled differently, sometimes being treated as floats when specifying expected column types, which causes inconsistencies and even hides some actual mismatches. ## What changes are included in this PR? 1. Adds a new column type `Decimal`, represented as `L` (for decima**L**). 2. Unifies all handling and formatting for the four decimal variants. 3. For the postgres engine, also split floats from the [`NUMERIC`](https://www.postgresql.org/docs/current/datatype-numeric.html) type. This surfaced a few places where PG returns a decimal but DataFusion returns a float (see for example `datafusion/sqllogictest/test_files/pg_compat/pg_compat_simple.slt`), all documented and now skipped for PG. 4. I've also reran the all tests with `--complete`, which makes a few random changes around empty whitespaces which I think is good to run periodically (I keep doing that locally in unrelated changes and having to `git restore` a bunch of files). Would it make sense to maybe add this check to CI and verify it leaves the worktree clean? ## Are these changes tested? Ran all tests locally ## Are there any user-facing changes? Users of `datafusion-sqllogictest` will get different results if they depend on the existing behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
