alamb commented on code in PR #23161:
URL: https://github.com/apache/datafusion/pull/23161#discussion_r3470302028
##########
datafusion/sqllogictest/test_files/pg_compat/pg_compat_simple.slt:
##########
@@ -325,6 +331,9 @@ AS tbl(int_col, float_col, negative_col, summation);
10 20 -30 4
+# DataFusion and Postgres infer different numeric return types here
+# (Float64 vs NUMERIC); this record checks DataFusion's type/value output.
+skipif postgres
Review Comment:
is there some way to get this just to skip the type check (but still do the
comparison)?
##########
datafusion/sqllogictest/src/engines/output.rs:
##########
@@ -49,6 +51,7 @@ impl ColumnType for DFColumnType {
Self::Timestamp => 'P',
Self::Float => 'R',
Self::Text => 'T',
+ Self::Decimal => 'L',
Review Comment:
Where did you get the `L` from? Is there some precedent for using "L"
somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
