AdamGS commented on code in PR #23161:
URL: https://github.com/apache/datafusion/pull/23161#discussion_r3505720457
##########
datafusion/sqllogictest/test_files/options.slt:
##########
@@ -209,20 +209,20 @@ query RT
select 123456789.0123456789012345678901234567890,
arrow_typeof(123456789.0123456789012345678901234567890)
----
-123456789.012345678901 Decimal256(40, 31)
+123456789.012345678901234567890123456789 Decimal256(40, 31)
query RT
select -123456789.0123456789012345678901234567890,
arrow_typeof(-123456789.0123456789012345678901234567890)
----
--123456789.012345678901 Decimal256(40, 31)
+-123456789.012345678901234567890123456789 Decimal256(40, 31)
# max precision and scale of Decimal256
query RTRT
select -1e-76, arrow_typeof(-1e-76),
-1.234567e-70, arrow_typeof(-1.234567e-70)
----
-0 Decimal256(76, 76) 0 Decimal256(76, 76)
+-0.0000000000000000000000000000000000000000000000000000000000000000000000000001
Decimal256(76, 76)
-0.0000000000000000000000000000000000000000000000000000000000000000000001234567
Decimal256(76, 76)
Review Comment:
I think this is an improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
