0lai0 commented on code in PR #4693:
URL: https://github.com/apache/datafusion-comet/pull/4693#discussion_r3500134670
##########
spark/src/test/spark-4.1/org/apache/spark/sql/CometCollationSuite.scala:
##########
@@ -172,6 +172,18 @@ class CometCollationSuite extends CometTestBase {
"date_format does not support non-UTF8_BINARY collations")
}
+ test("date_format uses native path with collated format when
allowIncompatible is enabled") {
Review Comment:
Thanks for the review! Consolidating these into the 4.1+ shim also needs
`add-test-source` in spark/pom.xml to pick up `minorPlusVerSrc` (right now only
the main-source `add-source` does), and the suite has to be moved rather than
copied to avoid a duplicate `CometCollationSuite` class on the 4.1 classpath.
I'll do that in a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
