andygrove commented on code in PR #4693:
URL: https://github.com/apache/datafusion-comet/pull/4693#discussion_r3481806406
##########
spark/src/test/spark-4.1/org/apache/spark/sql/CometCollationSuite.scala:
##########
@@ -172,6 +172,18 @@ class CometCollationSuite extends CometTestBase {
"date_format does not support non-UTF8_BINARY collations")
}
+ test("date_format uses native path with collated format when
allowIncompatible is enabled") {
Review Comment:
minor nit: this test is duplicated between 4.1 and 4.2 shims and could move
to the 4.1+ shim, which was recently introduced. We can do this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
