sweb opened a new pull request, #23989:
URL: https://github.com/apache/datafusion/pull/23989
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #23700 .
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
This is a clean up following #23649
## What changes are included in this PR?
- Moves the lambda-variable scope state out of `ExecutionProps` and into
`PhysicalPlanningContext`, following the same pattern as the scalar-subquery
state in #23649.
- Puts `PhysicalPlanningContext::indexes` behind an `Arc` so the new
per-lambda-body clone doesn't deep-copy the subquery index map.
`PhysicalPlanningContext::new`'s signature is unchanged.
## Are these changes tested?
- New `lambda_variables_shadow_outer_scope` unit test in
`physical_planning_context.rs` covers `with_qualified_lambda_variables` /
`lambda_variable_qualifier` directly, including an inner lambda shadowing an
outer parameter name.
## Are there any user-facing changes?
this is a breaking change for lib users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
