sweb commented on code in PR #23989: URL: https://github.com/apache/datafusion/pull/23989#discussion_r3707109094
########## docs/source/library-user-guide/upgrading/55.0.0.md: ########## @@ -774,6 +779,13 @@ Convenience methods such as `SessionContext::create_physical_expr` and parameter and forward it. - Code that read or wrote `execution_props.subquery_indexes` / `execution_props.subquery_results`: build a `PhysicalPlanningContext` instead. +- Code that read `execution_props.lambda_variable_qualifier` or called + `ExecutionProps::with_qualified_lambda_variables`: nothing to migrate. + `create_physical_expr` populates the lambda qualifiers itself as it descends + into lambda bodies, so callers planning a `HigherOrderFunction` do not need to + do anything. The equivalent state now lives on `PhysicalPlanningContext`, + reachable via `PhysicalPlanningContext::lambda_variable_qualifier` and + `PhysicalPlanningContext::with_qualified_lambda_variables`. Review Comment: addressed in https://github.com/apache/datafusion/pull/23989/changes/678073fb382e9ce126b81c8d9ab240530248c47c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
