sweb commented on code in PR #23989:
URL: https://github.com/apache/datafusion/pull/23989#discussion_r3707129655
##########
datafusion/physical-expr/src/planner.rs:
##########
@@ -612,15 +614,15 @@ pub fn create_physical_expr(
input_dfschema.metadata().clone(),
)?;
- let execution_props = execution_props
+ let planning_ctx = planning_ctx
.clone()
.with_qualified_lambda_variables(&qualifier,
&lambda.params);
Review Comment:
Not sure this concern holds up - this is planning time and once per lambda -
not per row. Also, I would not expect massive parameter lists of lambdas or
lambda chains - from my point of view due to the Arc this has already reduced
clone cost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
