Rachelint commented on PR #11943: URL: https://github.com/apache/datafusion/pull/11943#issuecomment-2285335297
Made a quick bench about this pr(without lto), seems no performance regression. ``` -------------------- Benchmark clickbench_partitioned.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Query ┃ main ┃ sketch-blocked-aggr-state-management ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ QQuery 0 │ 2.17ms │ 2.13ms │ no change │ │ QQuery 1 │ 57.70ms │ 57.59ms │ no change │ │ QQuery 2 │ 159.69ms │ 163.34ms │ no change │ │ QQuery 3 │ 173.27ms │ 170.30ms │ no change │ │ QQuery 4 │ 1641.20ms │ 1652.73ms │ no change │ │ QQuery 5 │ 1539.03ms │ 1524.73ms │ no change │ │ QQuery 6 │ 55.45ms │ 56.98ms │ no change │ │ QQuery 7 │ 61.20ms │ 62.59ms │ no change │ │ QQuery 8 │ 2385.40ms │ 2399.33ms │ no change │ │ QQuery 9 │ 1955.61ms │ 1960.52ms │ no change │ │ QQuery 10 │ 547.00ms │ 535.17ms │ no change │ │ QQuery 11 │ 603.61ms │ 601.63ms │ no change │ │ QQuery 12 │ 1720.48ms │ 1704.76ms │ no change │ │ QQuery 13 │ 3311.95ms │ 3323.39ms │ no change │ │ QQuery 14 │ 2516.42ms │ 2495.31ms │ no change │ │ QQuery 15 │ 1845.77ms │ 1846.49ms │ no change │ │ QQuery 16 │ 4954.26ms │ 4980.02ms │ no change │ │ QQuery 17 │ 4869.85ms │ 4894.41ms │ no change │ │ QQuery 18 │ 9829.83ms │ 9872.88ms │ no change │ │ QQuery 19 │ 139.56ms │ 142.35ms │ no change │ │ QQuery 20 │ 3664.25ms │ 3621.26ms │ no change │ │ QQuery 21 │ 4215.60ms │ 4204.44ms │ no change │ │ QQuery 22 │ 9206.41ms │ 9218.56ms │ no change │ │ QQuery 23 │ 22214.42ms │ 22208.78ms │ no change │ │ QQuery 24 │ 1078.21ms │ 1081.67ms │ no change │ │ QQuery 25 │ 880.96ms │ 877.46ms │ no change │ │ QQuery 26 │ 1264.48ms │ 1259.58ms │ no change │ │ QQuery 27 │ 5141.53ms │ 5129.23ms │ no change │ │ QQuery 28 │ 21850.81ms │ 21935.23ms │ no change │ │ QQuery 29 │ 873.95ms │ 874.71ms │ no change │ │ QQuery 30 │ 2026.89ms │ 2038.02ms │ no change │ │ QQuery 31 │ 2897.58ms │ 2900.44ms │ no change │ │ QQuery 32 │ 16180.65ms │ 15684.73ms │ no change │ │ QQuery 33 │ 9520.48ms │ 9679.00ms │ no change │ │ QQuery 34 │ 9604.84ms │ 9725.76ms │ no change │ │ QQuery 35 │ 3140.84ms │ 3183.50ms │ no change │ │ QQuery 36 │ 246.51ms │ 243.43ms │ no change │ │ QQuery 37 │ 113.85ms │ 114.18ms │ no change │ │ QQuery 38 │ 141.82ms │ 142.75ms │ no change │ │ QQuery 39 │ 818.31ms │ 839.21ms │ no change │ │ QQuery 40 │ 55.39ms │ 55.82ms │ no change │ │ QQuery 41 │ 47.59ms │ 48.47ms │ no change │ │ QQuery 42 │ 62.79ms │ 63.06ms │ no change │ └──────────────┴────────────┴──────────────────────────────────────┴───────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩ │ Total Time (main) │ 153617.61ms │ │ Total Time (sketch-blocked-aggr-state-management) │ 153575.92ms │ │ Average Time (main) │ 3572.50ms │ │ Average Time (sketch-blocked-aggr-state-management) │ 3571.53ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 43 │ └─────────────────────────────────────────────────────┴─────────────┘ Note: Skipping /home/db/datafusion/benchmarks/results/main/clickbench_partitioned.json.bak as /home/db/datafusion/benchmarks/results/sketch-blocked-aggr-state-management/clickbench_partitioned.json.bak does not exist -------------------- Benchmark tpch_mem_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Query ┃ main ┃ sketch-blocked-aggr-state-management ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ QQuery 1 │ 210.80ms │ 213.08ms │ no change │ │ QQuery 2 │ 31.73ms │ 31.97ms │ no change │ │ QQuery 3 │ 85.50ms │ 84.75ms │ no change │ │ QQuery 4 │ 61.82ms │ 61.04ms │ no change │ │ QQuery 5 │ 122.20ms │ 123.89ms │ no change │ │ QQuery 6 │ 13.02ms │ 13.10ms │ no change │ │ QQuery 7 │ 254.40ms │ 254.17ms │ no change │ │ QQuery 8 │ 27.28ms │ 27.32ms │ no change │ │ QQuery 9 │ 118.91ms │ 118.80ms │ no change │ │ QQuery 10 │ 117.97ms │ 117.72ms │ no change │ │ QQuery 11 │ 60.56ms │ 62.45ms │ no change │ │ QQuery 12 │ 36.34ms │ 37.95ms │ no change │ │ QQuery 13 │ 78.80ms │ 75.78ms │ no change │ │ QQuery 14 │ 15.23ms │ 15.68ms │ no change │ │ QQuery 15 │ 25.05ms │ 25.40ms │ no change │ │ QQuery 16 │ 36.55ms │ 37.96ms │ no change │ │ QQuery 17 │ 174.22ms │ 179.96ms │ no change │ │ QQuery 18 │ 488.36ms │ 486.20ms │ no change │ │ QQuery 19 │ 37.51ms │ 37.09ms │ no change │ │ QQuery 20 │ 81.47ms │ 81.72ms │ no change │ │ QQuery 21 │ 288.32ms │ 295.99ms │ no change │ │ QQuery 22 │ 19.94ms │ 19.90ms │ no change │ └──────────────┴──────────┴──────────────────────────────────────┴───────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main) │ 2385.98ms │ │ Total Time (sketch-blocked-aggr-state-management) │ 2401.93ms │ │ Average Time (main) │ 108.45ms │ │ Average Time (sketch-blocked-aggr-state-management) │ 109.18ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 22 │ └─────────────────────────────────────────────────────┴───────────┘ Note: Skipping /home/db/datafusion/benchmarks/results/main/tpch_sf10.json as /home/db/datafusion/benchmarks/results/sketch-blocked-aggr-state-management/tpch_sf10.json does not exist -------------------- Benchmark tpch_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ sketch-blocked-aggr-state-management ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 297.22ms │ 293.26ms │ no change │ │ QQuery 2 │ 46.87ms │ 47.34ms │ no change │ │ QQuery 3 │ 114.28ms │ 111.97ms │ no change │ │ QQuery 4 │ 63.56ms │ 62.58ms │ no change │ │ QQuery 5 │ 197.97ms │ 194.73ms │ no change │ │ QQuery 6 │ 55.43ms │ 54.90ms │ no change │ │ QQuery 7 │ 302.36ms │ 307.89ms │ no change │ │ QQuery 8 │ 127.47ms │ 126.77ms │ no change │ │ QQuery 9 │ 232.43ms │ 236.78ms │ no change │ │ QQuery 10 │ 201.49ms │ 194.57ms │ no change │ │ QQuery 11 │ 32.71ms │ 33.42ms │ no change │ │ QQuery 12 │ 85.82ms │ 85.40ms │ no change │ │ QQuery 13 │ 139.77ms │ 127.58ms │ +1.10x faster │ │ QQuery 14 │ 78.33ms │ 79.92ms │ no change │ │ QQuery 15 │ 110.22ms │ 106.46ms │ no change │ │ QQuery 16 │ 41.89ms │ 44.47ms │ 1.06x slower │ │ QQuery 17 │ 273.85ms │ 275.42ms │ no change │ │ QQuery 18 │ 456.45ms │ 453.82ms │ no change │ │ QQuery 19 │ 141.92ms │ 142.33ms │ no change │ │ QQuery 20 │ 132.11ms │ 136.81ms │ no change │ │ QQuery 21 │ 301.09ms │ 303.99ms │ no change │ │ QQuery 22 │ 27.21ms │ 26.33ms │ no change │ └──────────────┴──────────┴──────────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main) │ 3460.45ms │ │ Total Time (sketch-blocked-aggr-state-management) │ 3446.75ms │ │ Average Time (main) │ 157.29ms │ │ Average Time (sketch-blocked-aggr-state-management) │ 156.67ms │ │ Queries Faster │ 1 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 20 │ └─────────────────────────────────────────────────────┴───────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
