Rachelint commented on PR #11943: URL: https://github.com/apache/datafusion/pull/11943#issuecomment-2285799454
> I forgot it is sketch Yes, still not any detailed blocked impls now, and make benchmark for ensuring the sketch will not decrease the performance. I guess the blocked apporach may be not related much to `Emit::First`. And their relationship may be that the blocked emission is just something can be used to impl #9562 . Actually the blocked approach's main traget is that it manages the data block by block in the `GroupValues` and `GroupAccumulator`(need the new blocked impl for reaching this), which can avoid the copying cost compared to the single vector approach, it is actually similar as #7065 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
