Rachelint commented on code in PR #11943:
URL: https://github.com/apache/datafusion/pull/11943#discussion_r1714995356
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -353,7 +355,7 @@ pub(crate) struct GroupedHashAggregateStream {
/// scratch space for the current input [`RecordBatch`] being
/// processed. Reused across batches here to avoid reallocations
- current_group_indices: Vec<usize>,
+ current_group_indices: Vec<u64>,
Review Comment:
> what is the reason to use u64 instead of usize
I think the clearer u64 is needed when we impl the blocked impl,
we need to split the gourp_idx to two parts:
- high 32bits used to represent the `block id`
- low 32bits used to represent the `block offset`
So for reusing the same `current_group_indices` buffer in both `flat` and
`blocked` mode, I modify all related `group_idx` to u64.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
