Rachelint commented on PR #11943: URL: https://github.com/apache/datafusion/pull/11943#issuecomment-2286321387
> ~Does this improve memory usage~ I forgot it is sketch > > What is the difference between blocked approach and Emit::First with block size? At the end, there are only AllBlocks and FirstBlocks? I think maybe we should keep both `flat` impls and `blocked` impls (actually `flat` can be the special case of `blocked`, it always has just one single block). And `blocked emission` is optimized version of `Emit::All` and `Emit::First` to call, when we found the blocked mode is enable. When will the blocked mode be enabled maybe can see in: https://github.com/apache/datafusion/issues/11931#issuecomment-2283176521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
