JSOD11 commented on code in PR #23903:
URL: https://github.com/apache/datafusion/pull/23903#discussion_r3741421709
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -1402,11 +1437,12 @@ pub fn with_new_children_if_necessary(
}
// Layer 2: same child properties → reuse `PlanProperties` cache.
if has_same_children_properties(plan.as_ref(), &children)? {
- return plan.with_new_children_and_same_properties(children);
+ return plan
+ .replace_children(children,
ChildrenPropertiesHint::SameProperties);
}
}
// Layer 3: full recompute.
- plan.with_new_children(children)
+ plan.replace_children(children, ChildrenPropertiesHint::Recompute)
Review Comment:
I like this direction!
I pushed a new commit following your suggestion, moving us to
`replace_children_if_necessary` and marking `with_new_children_if_necessary` as
deprecated.
I migrated all the call sites to the new method and updated the upgrade
guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
