JSOD11 commented on code in PR #23903:
URL: https://github.com/apache/datafusion/pull/23903#discussion_r3741457912
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -1335,13 +1335,21 @@ impl ExecutionPlan for HashJoinExec {
/// This method is called during query optimization when the optimizer
creates new
/// plan nodes. Importantly, it creates a fresh bounds_accumulator via
`try_new`
/// rather than cloning the existing one because partitioning may have
changed.
- fn with_new_children(
+ fn replace_children(
self: Arc<Self>,
children: Vec<Arc<dyn ExecutionPlan>>,
+ _: ChildrenPropertiesHint,
) -> Result<Arc<dyn ExecutionPlan>> {
self.builder().with_new_children(children)?.build_exec()
Review Comment:
Yes, this makes sense to me, great find. As far as I understand there should
not be anything different about this join compared to the others that should
stop us from taking the fast path. I just added a new commit that uses the hint
to take the `SameProperties` path if applicable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
