mkleen commented on code in PR #23490:
URL: https://github.com/apache/datafusion/pull/23490#discussion_r3792235758
##########
datafusion/datasource/src/write/orchestration.rs:
##########
@@ -173,20 +235,32 @@ pub(crate) async fn stateless_serialize_and_write_files(
// if true, we may not have a guarantee that all written data was cleaned
up.
let mut any_abort_errors = false;
let mut join_set = JoinSet::new();
- while let Some((data_rx, serializer, writer)) = rx.recv().await {
+ while let Some((data_rx, serializer, writer, bytes_written)) =
rx.recv().await {
Review Comment:
`bytes_written` shadows `bytes_written` from line 229. I would suggest
change the name here, since this is confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]