CadyLinn commented on code in PR #23490:
URL: https://github.com/apache/datafusion/pull/23490#discussion_r3845080788
##########
datafusion/datasource-parquet/src/sink.rs:
##########
@@ -267,16 +266,12 @@ impl FileSink for ParquetSink {
mut file_stream_rx: DemuxedStreamReceiver,
object_store: Arc<dyn ObjectStore>,
) -> Result<u64> {
- let rows_written_counter = MetricBuilder::new(&self.metrics)
- .with_category(MetricCategory::Rows)
- .global_counter("rows_written");
+ let rows_written_counter = self.metrics.rows_written().clone();
Review Comment:
Fixed in the latest commit. FileSinkMetrics now creates fresh metric
instances for each sink execution, preventing counters from carrying over.
Added a regression test for this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
