mkleen commented on code in PR #23490:
URL: https://github.com/apache/datafusion/pull/23490#discussion_r3844710846
##########
datafusion/datasource-parquet/src/sink.rs:
##########
@@ -267,16 +266,12 @@ impl FileSink for ParquetSink {
mut file_stream_rx: DemuxedStreamReceiver,
object_store: Arc<dyn ObjectStore>,
) -> Result<u64> {
- let rows_written_counter = MetricBuilder::new(&self.metrics)
- .with_category(MetricCategory::Rows)
- .global_counter("rows_written");
+ let rows_written_counter = self.metrics.rows_written().clone();
Review Comment:
`rows_written_counter` is now a sink life time wide counter. This should
accumulate the counter if ran multiple times. I think we need each time a new
counter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
