github-actions[bot] commented on PR #23490: URL: https://github.com/apache/datafusion/pull/23490#issuecomment-5308524550
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-datasource v54.1.0 (current) Built [ 41.708s] (current) Parsing datafusion-datasource v54.1.0 (current) Parsed [ 0.035s] (current) Building datafusion-datasource v54.1.0 (baseline) Built [ 41.153s] (baseline) Parsing datafusion-datasource v54.1.0 (baseline) Parsed [ 0.036s] (baseline) Checking datafusion-datasource v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.381s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure method_requires_different_generic_type_params: method now requires a different number of generic type parameters --- Description: A method now requires a different number of generic type parameters than it used to. Uses of this method that supplied the previous number of generic types will be broken. ref: https://doc.rust-lang.org/reference/items/generics.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/method_requires_different_generic_type_params.ron Failed in: datafusion_datasource::file_compression_type::FileCompressionType::convert_async_writer_with_level takes 1 generic types instead of 0, in /home/runner/work/datafusion/datafusion/datafusion/datasource/src/file_compression_type.rs:171 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 85.109s] datafusion-datasource Building datafusion-datasource-csv v54.1.0 (current) Built [ 41.790s] (current) Parsing datafusion-datasource-csv v54.1.0 (current) Parsed [ 0.012s] (current) Building datafusion-datasource-csv v54.1.0 (baseline) Built [ 41.726s] (baseline) Parsing datafusion-datasource-csv v54.1.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-datasource-csv v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.140s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 86.083s] datafusion-datasource-csv Building datafusion-datasource-json v54.1.0 (current) Built [ 41.841s] (current) Parsing datafusion-datasource-json v54.1.0 (current) Parsed [ 0.013s] (current) Building datafusion-datasource-json v54.1.0 (baseline) Built [ 41.625s] (baseline) Parsing datafusion-datasource-json v54.1.0 (baseline) Parsed [ 0.015s] (baseline) Checking datafusion-datasource-json v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.126s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 84.613s] datafusion-datasource-json Building datafusion-datasource-parquet v54.1.0 (current) Built [ 46.983s] (current) Parsing datafusion-datasource-parquet v54.1.0 (current) Parsed [ 0.033s] (current) Building datafusion-datasource-parquet v54.1.0 (baseline) Built [ 47.131s] (baseline) Parsing datafusion-datasource-parquet v54.1.0 (baseline) Parsed [ 0.034s] (baseline) Checking datafusion-datasource-parquet v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.225s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 95.885s] datafusion-datasource-parquet Building datafusion-sqllogictest v54.1.0 (current) Built [ 96.819s] (current) Parsing datafusion-sqllogictest v54.1.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v54.1.0 (baseline) Built [ 97.437s] (baseline) Parsing datafusion-sqllogictest v54.1.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-sqllogictest v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.123s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 197.381s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
