andygrove commented on code in PR #5843:
URL: https://github.com/apache/datafusion-comet/pull/5843#discussion_r3990747929
##########
dev/ci/compute-changes.py:
##########
@@ -301,28 +301,43 @@
# Which events may run each job, independent of the path filters above.
#
# "pr" every pull request
+# "queue" the merge queue, i.e. a merge_group event
# "push" push to main
# "label:<name>" a pull request carrying that label
#
# workflow_dispatch always runs everything, so it is not listed. "pr" and
# "label:" are mutually exclusive -- a job is either unconditional on pull
# requests or opt-in, never both -- and check-ci-config.py rejects a job that
# lists both rather than letting the label quietly win.
+#
+# Almost everything is "queue": the merge queue is the authoritative gate, and
+# it tests the merge result rather than the PR head. "push" is reserved for
+# work that can only happen once a commit is on main. Adding "push" back to a
+# test job would make every merge run it twice, once in the queue and once
+# after, which is the thing the queue was adopted to avoid.
POLICY = {
- "build_linux": ["pr", "push"],
- "build_macos": ["pr", "push"],
- "benchmark": ["pr", "push"],
- # docs deploys to asf-site, so it must not run from a pull request.
+ "build_linux": ["pr", "queue"],
Review Comment:
Thanks @blaginin. I went ahead and addressed this in the current PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
