sunchao commented on code in PR #5843: URL: https://github.com/apache/datafusion-comet/pull/5843#discussion_r3991078036
########## .github/actions/download-artifact-retry/action.yaml: ########## @@ -0,0 +1,107 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: "Download Artifact (with retry)" +description: > + Drop-in replacement for actions/download-artifact that retries the download Review Comment: ### Correctness [P2] Register the new shared action in the consuming path filters. `FILTERS` lists `upload-artifact-retry/**` but never `download-artifact-retry/**`. For an edit confined to this new action, the current `compute()` returns every output false on both a PR update and `merge_group`, so none of its Linux/macOS/Spark/Iceberg consumers exercise the change. The existing config guard also passes that configuration. Add this path to the ten consuming filters and a corresponding `ROUTING_CASES` entry, as for the upload wrapper. I verified that adding only those dependencies in memory restores all ten queue routes. ########## .github/workflows/spark_sql_test_reusable.yml: ########## @@ -285,7 +285,9 @@ jobs: runs-on: ubuntu-24.04 steps: - name: Download fallback log artifacts - uses: actions/download-artifact@v8 + # Not wrapped in download-artifact-retry: that local action needs a + # checkout, which this job deliberately skips. + uses: ./.github/actions/download-artifact-retry Review Comment: ### Correctness [P2] Keep this download usable without a checkout. When a caller enables `collect-fallback-logs`, this job starts on its own runner and its first step now references `./.github/actions/download-artifact-retry`, but no step has checked out that directory. The action cannot be loaded, so the merged fallback-log artifact is no longer produced. The preceding comment describes the intended exception, but the `uses` value does the opposite. Restore `actions/download-artifact@v8` here, or add a checkout before the local action. Current umbrella callers leave the option false, which explains why ordinary CI does not exercise this regression. [GitHub's local-action requirement](https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-using-an-action-in-the-same-repository-as-the-workflow) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
