andygrove commented on code in PR #5843:
URL: https://github.com/apache/datafusion-comet/pull/5843#discussion_r3992867446
##########
.github/workflows/spark_sql_test_reusable.yml:
##########
@@ -285,7 +285,9 @@ jobs:
runs-on: ubuntu-24.04
steps:
- name: Download fallback log artifacts
- uses: actions/download-artifact@v8
+ # Not wrapped in download-artifact-retry: that local action needs a
+ # checkout, which this job deliberately skips.
+ uses: ./.github/actions/download-artifact-retry
Review Comment:
Good catch, and the worst combination: the comment was right and the `uses:`
was wrong. Restored `actions/download-artifact@v8` in f36626df.
Since no caller sets `collect-fallback-logs`, a comment was never going to
hold that line, so I also added a fifth invariant to `check-ci-config.py` — any
`uses: ./.github/actions/...` in a workflow needs an `actions/checkout` earlier
in the same job. Reintroducing the bad `uses:` now fails preflight naming
exactly that step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
