andygrove commented on PR #5843: URL: https://github.com/apache/datafusion-comet/pull/5843#issuecomment-5639868926
Thanks @sunchao. You're right about the queue parameters, and it's worse than a wording problem — GitHub says outright that merge limits do not combine `merge_group` builds, so `max_entries_to_merge: 5` saves no CI whatsoever. I had the cost model backwards. `.asf.yaml`, the workflows README and the PR description all asserted the batching; all three are corrected in 6cacd83. While rewriting those comments I noticed the `ALLGREEN` one was describing HEADGREEN's behaviour — "a batch is only merged if the combined tree is green" is the green-head rule, not the all-green one. Fixed that too. The correction also moves where the real constraint sits. With every entry getting its own build, `max_entries_to_build: 2` is the throughput ceiling rather than a speculation-cost knob: two pipelines at the ~2.5h we see today drains roughly 19 merges a day. Over the last 30 days `main` took a median of 6 merges a day but 22 on the busiest, so 2 would have been the bottleneck on the worst day. I've left it at 2 and written those numbers into the comment rather than changing the value, since raising it costs that many concurrent ASF runners and that felt like a call to make deliberately rather than fold into this PR. Happy to start at 3 if you think that's the safer default. The case for the split itself is unaffected: the saving comes from the PR tier being small, not from anything the queue batches. And agreed on the rollout caveat — the ruleset and the `merge_group` paths are proposed configuration until it's live, which is why #5842 landed `Required Checks` on its own first so we could at least confirm the required context reports correctly on real PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
