NoahKusaba commented on code in PR #2438:
URL:
https://github.com/apache/datafusion-ballista/pull/2438#discussion_r3994371417
##########
docs/source/user-guide/extending-components.md:
##########
@@ -193,7 +198,6 @@ ctx.sql("SET s3.endpoint = 'http://localhost:9000'")
.await?
.show()
.await?;
-ctx.sql("SET s3.allow_http = true").await?.show().await?;
Review Comment:
This is actually a redundant call!
If you check line 185, the ctx already calls "SET s3.allow_http = true".
custom-client.rs also has the redundant "SET s3.allow_http = true" as well.
I've removed it from the example to remove confusion (in my follow up
commit). Let me know if that works for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
