NoahKusaba commented on code in PR #2438: URL: https://github.com/apache/datafusion-ballista/pull/2438#discussion_r3994560509
########## docs/source/user-guide/metrics.md: ########## @@ -23,20 +23,19 @@ > This is optional scheduler feature which should be enabled with > `prometheus-metrics` feature -Built with default features, the ballista scheduler will automatically collect and expose a standard set of prometheus metrics. -The metrics currently collected automatically include: +Built with the `prometheus-metrics` feature, the ballista scheduler collects and exposes a standard set of +prometheus metrics. The metrics collected are: - _job_exec_time_seconds_ - Histogram of successful job execution time in seconds - _planning_time_ms_ - Histogram of job planning time in milliseconds -- _failed_ - Counter of failed jobs Review Comment: Thanks for the feedback, I removed the stale name as you suggested. I also noticed the header says "7 metrics" but listed 8, with `failed` as the extra. Documented names and registered names now both come to 7 and match exactly (checked by extracting both sets, not by eye). Verified with `--features prometheus-metrics`, since the default build never compiles that file: check, fmt and `cargo doc` under `-D warnings` all pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
