NoahKusaba commented on code in PR #2438:
URL:
https://github.com/apache/datafusion-ballista/pull/2438#discussion_r3994465499
##########
.github/workflows/build.yml:
##########
@@ -94,9 +94,13 @@ jobs:
# Update output format to enable automatic inline annotations.
- name: Run Ruff
run: |
+ # Linted from the repository root, not just python/: dev/,
benchmarks/
+ # and docs/source/conf.py are Python too. Ruff resolves the nearest
+ # config per file, so python/ still uses python/pyproject.toml and
+ # everything else uses the root ruff.toml.
cd python
- uv run --no-project ruff check --output-format=github .
- uv run --no-project ruff format --check .
+ uv run --no-project ruff check --output-format=github ..
Review Comment:
AI Validation:
Thanks — I checked this by planting a deliberate F401 and reading the raw
workflow command. Ruff doesn't emit `../`; with `--output-format=github` it
writes an absolute path into `file=`, which is what GitHub uses to place the
annotation.
For the same finding, `file=` is byte-identical across all three:
before (cd python, `.`) file=/…/python/python/ballista/jupyter.py
this PR (cd python, `..`) file=/…/python/python/ballista/jupyter.py
root (root, `.`) file=/…/python/python/ballista/jupyter.py
So annotations behave exactly as they did before this PR. What does change
with
the working directory is the human-readable text after the `::`, which GitHub
ignores for placement — I suspect that's what you spotted in the log.
Happy to run from the root anyway if you prefer the shorter log paths, though
the `cd python` is load-bearing (it's how `uv run --no-project` finds the
synced
venv), so it'd need to invoke `python/.venv/bin/ruff` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
