NoahKusaba commented on code in PR #2438: URL: https://github.com/apache/datafusion-ballista/pull/2438#discussion_r3994518534
########## docs/source/user-guide/extending-components.md: ########## @@ -32,21 +32,24 @@ new configuration extensions, object stores, logical and physical codecs ... Ballista executor can be configured using `ExecutorProcessConfig` which supports overriding `function registry`,`runtime producer`, `config producer`, `logical codec`, `physical codec`. -Ballista scheduler can be tunned using `SchedulerConfig` which supports overriding `config producer`, `session builder`, `logical codec`, `physical codec` +Ballista scheduler can be tuned using `SchedulerConfig` which supports overriding `config producer`, `session builder`, `logical codec`, `physical codec` ## Example: Custom Object Store Integration Extending basic building blocks will be demonstrated by integrating S3 object store. For this, new `ObjectStoreRegistry` and `S3Options` will be provided. `ObjectStoreRegistry` creates new `ObjectStore` instances configured using `S3Options`. For this specific task `config producer`, `runtime producer` and `session builder` have to be provided, and client, scheduler and executor need to be configured. +These three functions ship in `ballista_core::object_store`, so the snippets below are the +shipped implementations rather than something you have to write from scratch. Review Comment: Thanks for the catch! Rather than re-copy it, I've pulled all three helpers from the source with `literalinclude` (`:start-at:`/`:end-before:` on the doc comments, so no line numbers to rot) in bcb05453. Verified against the built HTML: the rendered block is byte-identical to the source slice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
