dwsmith1983 commented on PR #5872: URL: https://github.com/apache/datafusion-comet/pull/5872#issuecomment-5665630364
> Would it make sense to accept that FQCN as a third alias here and add it to the `datasources.md` row, so the configuration Hadoop actually documents works on both sides? Added `org.apache.hadoop.fs.s3a.auth.ProfileAWSCredentialsProvider` as the provider that reads the profile keys, with its own row. The SDK spellings now resolve the SDK default profile and ignore the keys, since Hadoop constructs those without its configuration, so both halves of a job resolve the same identity. A test pins that for both SDK spellings and the chain test uses the Hadoop provider. > Could we add a sentence saying deployments that relied on the previous always-path-style behavior need to set `fs.s3a.path.style.access=true`? Added, right after the addressing paragraph. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
