dwsmith1983 commented on PR #5872:
URL: 
https://github.com/apache/datafusion-comet/pull/5872#issuecomment-5690511423

   > Could we resolve the omitted default in the executor JVM before creating 
the native provider, while preserving explicit file overrides?
   
   Done. The driver no longer forwards anything for it. 
`CometExecIterator.serializeCometSQLConfs`, which runs on the executor when a 
native plan is created (the shuffle writer path included), now carries 
`fs.s3a.comet.default.profile.file` resolved against that executor's 
`user.home` or `AWS_SHARED_CREDENTIALS_FILE`; native keeps it as a session 
extension and overlays it onto each scan's object store options, and the 
Hadoop-provider arm takes a configured `fs.s3a.auth.profile.file` first, then 
that path. With different driver and executor homes the executor's wins. Tests: 
the serialized executor config carries the resolved path, planning on the 
driver forwards nothing, the overlay replaces a driver-serialized value and is 
a no-op without the extension, and the provider arm prefers an explicit file. 
Merged with `main` at 3868760f9.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to