rluvaton commented on issue #24704: URL: https://github.com/apache/datafusion/issues/24704#issuecomment-5775233030
@alamb @Dandandan @comphead @jayzhan211 I want to push this forward, the one question remaining is: Do we want to change the existing trait for `GroupsAccumulator` or create a new one for the `BlockedGroupsAccumulator` with an adapter for `GroupsAccumulator` so existing implementation would still work and it can be incrementally migrated. From my benchmarks doing continues state/evaluate with emit to first which shifts is really expensive (from what I remember can be 4 times slower). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
