alamb commented on issue #24704: URL: https://github.com/apache/datafusion/issues/24704#issuecomment-5779224922
> No strong preference on my side — either approach works for me as long as we get the result. I'm also fine if the first version is harder to review; we can look at simplifying it afterwards. I agree too. I think for this work I would suggest: 1. Get a PR up with the base pattern for one or two accumulators, so we can validate the design/pattern carefully 2. then we can mechanically switch over the other accumulators to the new pattern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
