jayzhan211 commented on issue #24704: URL: https://github.com/apache/datafusion/issues/24704#issuecomment-5778772982
> Do we want to change the existing trait for GroupsAccumulator or create a new one for the BlockedGroupsAccumulator with an adapter for GroupsAccumulator so existing implementation would still work and it can be incrementally migrated No strong preference on my side — either approach works for me as long as we get the result. I'm also fine if the first version is harder to review; we can look at simplifying it afterwards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
