kosiew commented on code in PR #25570:
URL: https://github.com/apache/datafusion/pull/25570#discussion_r4180821042
##########
benchmarks/src/statistics.rs:
##########
@@ -184,7 +184,10 @@ impl RunOpt {
let logical_plan = state.optimize(&logical_plan)?;
let physical_plan = state.create_physical_plan(&logical_plan).await?;
- let statistics = capture_statistics(physical_plan.as_ref())?;
+ let statistics = capture_statistics(
Review Comment:
The main behavior change here is not covered by an assertion, so reverting
to `StatisticsRegistry::default_with_builtin_providers()` would still let the
existing tests pass. Please add a `report_statement` test with a `SessionState`
that installs a distinguishing `StatisticsRegistry` provider, for example one
that returns `Inexact(42)` rows, and assert that estimate appears in the report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
