gabotechs commented on code in PR #25570:
URL: https://github.com/apache/datafusion/pull/25570#discussion_r4183513489
##########
benchmarks/src/statistics.rs:
##########
@@ -184,7 +184,10 @@ impl RunOpt {
let logical_plan = state.optimize(&logical_plan)?;
let physical_plan = state.create_physical_plan(&logical_plan).await?;
- let statistics = capture_statistics(physical_plan.as_ref())?;
+ let statistics = capture_statistics(
Review Comment:
I added a `report_statement` regression test in d988cdf870 using a
`SessionStateBuilder` registry with a `ClosureStatisticsProvider` that returns
`Inexact(42)`, and asserted that the report contains that estimate. I also
verified the test fails with `default_with_builtin_providers()` restored (it
reports `Exact(1)`) and passes with the session registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
